Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump go to 1.22, k8s deps to 0.30.0 #176

Merged

Conversation

everettraven
Copy link
Collaborator

Description of the change:

  • Bumps go to 1.22
  • Bumps k8s deps to 0.30.0
  • Bumps controller-runtime to 0.18.2
  • Updates handler package so that handlers satisfy the updated controller-runtime APIs that use generics

Motivation for the change:

  • support go 1.22 and k8s 1.30

go.mod Outdated Show resolved Hide resolved
Comment on lines +150 to +151
var obj client.Object = evt.Object
if obj == nil {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was needed to maintain the existing expectations of the API where a nil object in the event would result in returning a default filter value

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 92.45283% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 88.88%. Comparing base (b394e34) to head (4d3d4c4).

Files Patch % Lines
handler/pause.go 0.00% 2 Missing ⚠️
predicate/pause.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #176      +/-   ##
==========================================
+ Coverage   88.71%   88.88%   +0.17%     
==========================================
  Files          17       18       +1     
  Lines         567      576       +9     
==========================================
+ Hits          503      512       +9     
  Misses         51       51              
  Partials       13       13              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: everettraven <everettraven@gmail.com>
@everettraven
Copy link
Collaborator Author

Squashed commits

Copy link
Member

@rashmigottipati rashmigottipati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2024
@everettraven everettraven added this pull request to the merge queue May 16, 2024
Merged via the queue into operator-framework:main with commit bf5fa88 May 16, 2024
5 of 6 checks passed
@everettraven everettraven deleted the chore/bump-k8s-1.30 branch May 16, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants